Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: components/policy/core/common/policy_loader_mac_unittest.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/policy_loader_mac_unittest.cc
diff --git a/components/policy/core/common/policy_loader_mac_unittest.cc b/components/policy/core/common/policy_loader_mac_unittest.cc
index 0684a6abc579fab54609697b05147988e90f5e8f..fe1f77dc9d8d1d2079e02debea7c8506d00a573f 100644
--- a/components/policy/core/common/policy_loader_mac_unittest.cc
+++ b/components/policy/core/common/policy_loader_mac_unittest.cc
@@ -108,7 +108,7 @@ void TestHarness::InstallBooleanPolicy(const std::string& policy_name,
void TestHarness::InstallStringListPolicy(const std::string& policy_name,
const base::ListValue* policy_value) {
ScopedCFTypeRef<CFStringRef> name(base::SysUTF8ToCFStringRef(policy_name));
- ScopedCFTypeRef<CFPropertyListRef> array(ValueToProperty(policy_value));
+ ScopedCFTypeRef<CFPropertyListRef> array(ValueToProperty(*policy_value));
ASSERT_TRUE(array);
prefs_->AddTestItem(name, array, true);
}
@@ -117,7 +117,7 @@ void TestHarness::InstallDictionaryPolicy(
const std::string& policy_name,
const base::DictionaryValue* policy_value) {
ScopedCFTypeRef<CFStringRef> name(base::SysUTF8ToCFStringRef(policy_name));
- ScopedCFTypeRef<CFPropertyListRef> dict(ValueToProperty(policy_value));
+ ScopedCFTypeRef<CFPropertyListRef> dict(ValueToProperty(*policy_value));
ASSERT_TRUE(dict);
prefs_->AddTestItem(name, dict, true);
}
« no previous file with comments | « components/policy/core/common/mac_util_unittest.cc ('k') | components/policy/core/common/policy_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698