components/policy/core/common/mac_util_unittest.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/mac_util_unittest.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippets_service.cc ('k') | components/policy/core/common/policy_loader_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/mac_util_unittest.cc

diff --git a/components/policy/core/common/mac_util_unittest.cc b/components/policy/core/common/mac_util_unittest.cc

index 46f108a8a02b085d713503e2eac3d71b35403326..c082dafa509c4d00c1aefe211576863638e930e1 100644

--- a/components/policy/core/common/mac_util_unittest.cc

+++ b/components/policy/core/common/mac_util_unittest.cc

@@ -52,7 +52,7 @@ TEST(PolicyMacUtilTest, PropertyToValue) {

// Very meta.

root.Set("dict", root.DeepCopy());

- base::ScopedCFTypeRef<CFPropertyListRef> property(ValueToProperty(&root));

+ base::ScopedCFTypeRef<CFPropertyListRef> property(ValueToProperty(root));

ASSERT_TRUE(property);

std::unique_ptr<base::Value> value = PropertyToValue(property);

ASSERT_TRUE(value);

« no previous file with comments | « components/ntp_snippets/ntp_snippets_service.cc ('k') | components/policy/core/common/policy_loader_mac_unittest.cc » ('j') | no next file with comments »