chrome/browser/spellchecker/spellcheck_service.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/managed_bookmarks_policy_handler.cc ('k') | chrome/browser/supervised_user/supervised_user_site_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_service.cc

diff --git a/chrome/browser/spellchecker/spellcheck_service.cc b/chrome/browser/spellchecker/spellcheck_service.cc

index 180823d8d90bd25f7740319e659be315ef5c8c19..a7ba7ce6c8079f29f0d1cfd198d51b9785743d01 100644

--- a/chrome/browser/spellchecker/spellcheck_service.cc

+++ b/chrome/browser/spellchecker/spellcheck_service.cc

@@ -225,7 +225,7 @@ void SpellcheckService::LoadHunspellDictionaries() {

const base::ListValue* dictionary_values =

prefs->GetList(prefs::kSpellCheckDictionaries);

- for (const base::Value* dictionary_value : *dictionary_values) {

+ for (const auto& dictionary_value : *dictionary_values) {

std::string dictionary;

dictionary_value->GetAsString(&dictionary);

hunspell_dictionaries_.push_back(new SpellcheckHunspellDictionary(