chrome/browser/policy/managed_bookmarks_policy_handler.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/managed_bookmarks_policy_handler.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/policy/managed_bookmarks_policy_handler.cc

diff --git a/chrome/browser/policy/managed_bookmarks_policy_handler.cc b/chrome/browser/policy/managed_bookmarks_policy_handler.cc

index 3c144247ef721194e33d176c92b8386c472fac6c..58bb19843be8fe748cea5f74cbae60cc3d5ac606 100644

--- a/chrome/browser/policy/managed_bookmarks_policy_handler.cc

+++ b/chrome/browser/policy/managed_bookmarks_policy_handler.cc

@@ -49,7 +49,7 @@ void ManagedBookmarksPolicyHandler::ApplyPolicySettings(

std::string

ManagedBookmarksPolicyHandler::GetFolderName(const base::ListValue& list) {

// Iterate over the list, and try to find the FolderName.

- for (auto el : list) {

+ for (const auto& el : list) {

const base::DictionaryValue* dict = NULL;

if (!el || !el->GetAsDictionary(&dict)) continue;

« no previous file with comments | « chrome/browser/plugins/plugin_prefs.cc ('k') | chrome/browser/spellchecker/spellcheck_service.cc » ('j') | no next file with comments »