Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: chrome/browser/chromeos/arc/arc_policy_bridge.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_policy_bridge.cc
diff --git a/chrome/browser/chromeos/arc/arc_policy_bridge.cc b/chrome/browser/chromeos/arc/arc_policy_bridge.cc
index 67f9e6837d0fedb8fcda2f46ea8ef70dc186f91d..3cbc920e09cb0042bcc5b64124f21e56eec6d9f5 100644
--- a/chrome/browser/chromeos/arc/arc_policy_bridge.cc
+++ b/chrome/browser/chromeos/arc/arc_policy_bridge.cc
@@ -129,7 +129,7 @@ void AddOncCaCertsToPolicies(const policy::PolicyMap& policy_map,
std::unique_ptr<base::ListValue> ca_certs(
base::WrapUnique(new base::ListValue()));
- for (const auto entry : certificates) {
+ for (const auto& entry : certificates) {
const base::DictionaryValue* certificate = nullptr;
if (!entry->GetAsDictionary(&certificate)) {
DLOG(FATAL) << "Value of a certificate entry is not a dictionary "
« no previous file with comments | « chrome/browser/banners/app_banner_settings_helper.cc ('k') | chrome/browser/chromeos/login/ui/webui_login_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698