| Index: chrome/browser/banners/app_banner_settings_helper.cc
|
| diff --git a/chrome/browser/banners/app_banner_settings_helper.cc b/chrome/browser/banners/app_banner_settings_helper.cc
|
| index 0e0f24bf79a45e5b4fc492facbadbd2a082621ea..068a7c509b0ee3e750ee93e80b8581ec54117aed 100644
|
| --- a/chrome/browser/banners/app_banner_settings_helper.cc
|
| +++ b/chrome/browser/banners/app_banner_settings_helper.cc
|
| @@ -334,8 +334,7 @@ void AppBannerSettingsHelper::RecordBannerCouldShowEvent(
|
| // Trim any items that are older than we should care about. For comparisons
|
| // the times are converted to local dates.
|
| base::Time date = BucketTimeToResolution(time, gMinimumMinutesBetweenVisits);
|
| - base::ValueVector::iterator it = could_show_list->begin();
|
| - while (it != could_show_list->end()) {
|
| + for (auto it = could_show_list->begin(); it != could_show_list->end();) {
|
| if ((*it)->IsType(base::Value::TYPE_DICTIONARY)) {
|
| base::DictionaryValue* internal_value;
|
| double internal_date;
|
| @@ -476,7 +475,7 @@ AppBannerSettingsHelper::GetCouldShowBannerEvents(
|
| if (!app_dict->GetList(event_key, &could_show_list))
|
| return result;
|
|
|
| - for (auto value : *could_show_list) {
|
| + for (const auto& value : *could_show_list) {
|
| if (value->IsType(base::Value::TYPE_DICTIONARY)) {
|
| base::DictionaryValue* internal_value;
|
| double internal_date = 0;
|
|
|