Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1885)

Unified Diff: buildbot/scripts/common/chromium_config.py

Issue 200074: Add back icudt38.dll to the list of files to archive and the list of files fo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | buildbot/scripts/slave/chromium/archive_build.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/scripts/common/chromium_config.py
===================================================================
--- buildbot/scripts/common/chromium_config.py (revision 25714)
+++ buildbot/scripts/common/chromium_config.py (working copy)
@@ -123,7 +123,10 @@
# List of symbol files to save, but not to upload to the symbol server
# (generally because they have no symbols and thus would produce an error).
- symbols_to_skip_upload = ['icudt42.dll', 'rlz.dll',]
+ # TODO(jungshik): make the name of icudt dll independent of the ICU version.
+ # For now, we list both icudt{38,42}.dll because this script is used by
+ # pre-ICU 4.2 builds as well.
+ symbols_to_skip_upload = ['icudt38.dll', 'icudt42.dll', 'rlz.dll',]
if os.environ.get('CHROMIUM_BUILD', '') == '_google_chrome':
exes_to_skip_entirely = []
@@ -148,9 +151,13 @@
installer_exe = Installer.installer_exe
# Test files to archive.
+ # TODO(jungshik): make the name of icudt dll independent of the ICU version.
+ # For now, we list both icudt{38,42}.dll because this script is used by
+ # pre-ICU 4.2 builds as well.
tests_to_archive = ['reliability_tests.exe',
'test_shell.exe',
'automated_ui_tests.exe',
+ 'icudt38.dll',
'icudt42.dll',
'plugins\\npapi_layout_test_plugin.dll',
]
« no previous file with comments | « no previous file | buildbot/scripts/slave/chromium/archive_build.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698