Add back icudt38.dll to the list of files to archive and the list of files fo...

buildbot/scripts/common/chromium_config.py

 #!/usr/bin/python
 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Declares a number of site-dependent variables for use by scripts.
 
 A typical use of this module would be
 
   import chromium_config as config
@@ skipping 105 matching lines @@
   # It really sucks to have to hard-code these here.
   # TODO(cpu): rlz_pdb.dll dropped from list. http://b/1716253
   symbols_to_archive = ['chrome_dll.pdb', 'chrome_exe.pdb',
                         'mini_installer.pdb', 'setup.pdb']
 
   # Binary to archive on the source server with the sourcified symbols.
   symsrc_binaries = ['chrome.exe', 'chrome.dll']
 
   # List of symbol files to save, but not to upload to the symbol server
   # (generally because they have no symbols and thus would produce an error).
-  symbols_to_skip_upload = ['icudt42.dll', 'rlz.dll',]
+  # TODO(jungshik): make the name of icudt dll independent of the ICU version.
+  # For now, we list both icudt{38,42}.dll because this script is used by
+  # pre-ICU 4.2 builds as well.
+  symbols_to_skip_upload = ['icudt38.dll', 'icudt42.dll', 'rlz.dll',]
 
   if os.environ.get('CHROMIUM_BUILD', '') == '_google_chrome':
     exes_to_skip_entirely = []
   else:
     # Skip any filenames (exes, symbols, etc.) starting with these strings
     # entirely, typically because they're not built for this distribution.
     exes_to_skip_entirely = ['rlz']
 
   # Extra files to archive in official mode.
   if chromium_utils.IsWindows():
     official_extras = [
       ['setup.exe'],
       ['chrome.packed.7z'],
       ['patch.packed.7z'], 
       ['obj', 'mini_installer', 'mini_installer_exe_version.rc'],
       ['courgette.exe'], 
     ]
   else:
     official_extras = []
 
   # Installer to archive.
   installer_exe = Installer.installer_exe
 
   # Test files to archive.
+  # TODO(jungshik): make the name of icudt dll independent of the ICU version.
+  # For now, we list both icudt{38,42}.dll because this script is used by
+  # pre-ICU 4.2 builds as well.
   tests_to_archive = ['reliability_tests.exe',
                       'test_shell.exe',
                       'automated_ui_tests.exe',
+                      'icudt38.dll',
                       'icudt42.dll',
                       'plugins\\npapi_layout_test_plugin.dll',
                      ]
 
   # Archive everything in these directories, using glob.
   test_dirs_to_archive = ['fonts']
   # Create these directories, initially empty, in the archive.
   test_dirs_to_create = ['plugins', 'fonts']
 
   # Directories in which to store built files, for dev, official, and full
@@ skipping 33 matching lines @@
 
   # Any URLs found in IRC topics will be passed as %s to this format before
   # being added to the topic-list page. It must contain exactly one "%s" token.
   # To disable URL mangling, set this to "%s".
   href_redirect_format = 'http://www.google.com/url?sa=D&q=%s'
 
 
 class Distributed(chromium_config_private.Distributed):
   # File holding current version information.
   version_file = Installer.version_file