third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2000683002: Keep writing-mode in sync between a column spanner and its placeholder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2000683002: Keep writing-mode in sync between a column spanner and its placeholder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: There should no longer be any need for LayoutTable to propagateStyleToAnonymousChildren(), since La… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/span/change-multicol-writing-mode-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutFullScreen.h » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 316305c8422ab5c53f5d143851368bc1b25e1354..d7347a067b9b0baaa4909b5e922f6ec1d9e51cb3 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -229,7 +229,7 @@ void LayoutBlock::styleDidChange(StyleDifference diff, const ComputedStyle* oldS

if (TextAutosizer* textAutosizer = document().textAutosizer())

textAutosizer->record(this);

- propagateStyleToAnonymousChildren(true);

+ propagateStyleToAnonymousChildren();

// It's possible for our border/padding to change, but for the overall logical width or height of the block to

// end up being the same. We keep track of this change so in layoutBlock, we can know to set relayoutChildren=true.