ios/web/net/cert_host_pair.h - Issue 2000503002: Remove the fingerprint and ca_fingerprint from X509Certificate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/net/cert_host_pair.h

Issue 2000503002: Remove the fingerprint and ca_fingerprint from X509Certificate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_cache

Patch Set: Fix Win & iOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/web/navigation/crw_session_certificate_policy_manager.mm ('K') | « ios/web/navigation/crw_session_certificate_policy_manager.mm ('k') | ios/web/net/cert_host_pair.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/net/cert_host_pair.h

diff --git a/ios/web/net/cert_host_pair.h b/ios/web/net/cert_host_pair.h

index f251c1b5727dbaba14ea94260b37768c88841471..6477a9d5fac033e5e1656057120aed0306b54261 100644

--- a/ios/web/net/cert_host_pair.h

+++ b/ios/web/net/cert_host_pair.h

@@ -8,6 +8,7 @@

#include <string>

#include "base/memory/ref_counted.h"

+#include "net/base/hash_value.h"

namespace net {

class X509Certificate;

@@ -27,6 +28,7 @@ struct CertHostPair {

scoped_refptr<net::X509Certificate> cert;

std::string host;

+ const net::SHA256HashValue cert_hash;

Eugene But (OOO till 7-30) 2016/06/16 01:14:34 Should |cert| field be private or at least const?

Ryan Sleevi 2016/06/16 01:19:44 Actually making CertHostPair a proper class, with

Eugene But (OOO till 7-30) 2016/06/16 01:36:23 That sounds even better and totally reasonable to

};

} // namespace web