Remove the fingerprint and ca_fingerprint from X509Certificate

ios/web/net/cert_host_pair.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_NET_CERT_HOST_PAIR_H_
 #define IOS_WEB_NET_CERT_HOST_PAIR_H_
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
+#include "net/base/hash_value.h"
 
 namespace net {
 class X509Certificate;
 }
 
 namespace web {
 
 // Holds certificate-host pair. Implements operator less, hence can act as a key
 // for a container.
 struct CertHostPair {
   CertHostPair(const scoped_refptr<net::X509Certificate>& cert,
                const std::string& host);
   CertHostPair(const CertHostPair& other);
   ~CertHostPair();
 
   bool operator<(const CertHostPair& other) const;
 
   scoped_refptr<net::X509Certificate> cert;
   std::string host;
+  const net::SHA256HashValue cert_hash;

[Eugene But (OOO till 7-30), 2016/06/16 01:14:34]

Should |cert| field be private or at least const? With adding |cert_hash| field
this API is now error prone (f.e. callers can change |cert| and break the
comparison). 

[Ryan Sleevi, 2016/06/16 01:19:44]

Actually making CertHostPair a proper class, with all members private, more
accurately reflects its usage. If you're fine with that, I'd love to make this
change - but was trying not to scope-creep too much.

[Eugene But (OOO till 7-30), 2016/06/16 01:36:23]

That sounds even better and totally reasonable to do in a separate CL.

 };
 
 }  // namespace web
 
 #endif  // IOS_WEB_NET_CERT_HOST_PAIR_H_