storage/browser/blob/blob_reader.cc - Issue 2000483004: [BlobReader] Correct IsInMemory = false when async constructing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/blob/blob_reader.cc

Issue 2000483004: [BlobReader] Correct IsInMemory = false when async constructing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests, and comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: storage/browser/blob/blob_reader.cc

diff --git a/storage/browser/blob/blob_reader.cc b/storage/browser/blob/blob_reader.cc

index 2eafdbcc77e6fcdbc8e4ef1d00248d3f5db4f22e..b342fc907c5edad6efe5060b4f59bb1139351a68 100644

--- a/storage/browser/blob/blob_reader.cc

+++ b/storage/browser/blob/blob_reader.cc

@@ -226,6 +226,9 @@ void BlobReader::Kill() {

}

bool BlobReader::IsInMemory() const {

+ if (blob_handle_ && blob_handle_->IsBeingBuilt()) {

+ return false;

+ }

if (!blob_data_.get()) {

return true;

}

« no previous file with comments | « storage/browser/blob/blob_reader.h ('k') | no next file » | no next file with comments »