storage/browser/blob/blob_reader.h - Issue 2000483004: [BlobReader] Correct IsInMemory = false when async constructing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/blob/blob_reader.h

Issue 2000483004: [BlobReader] Correct IsInMemory = false when async constructing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests, and comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: storage/browser/blob/blob_reader.h

diff --git a/storage/browser/blob/blob_reader.h b/storage/browser/blob/blob_reader.h

index a3c7cfa10a52ec1e6a7d8a9c1029de5a9780b447..0a5a4b44c82a41146abc031d67d4397e011be68c 100644

--- a/storage/browser/blob/blob_reader.h

+++ b/storage/browser/blob/blob_reader.h

@@ -120,7 +120,8 @@ class STORAGE_EXPORT BlobReader {

// after this call.

void Kill();

- // Returns if all of the blob's items are in memory.

+ // Returns if all of the blob's items are in memory. Should only be called

+ // after CalculateSize.

bool IsInMemory() const;

// Returns the remaining bytes to be read in the blob. This is populated

« no previous file with comments | « net/base/upload_element_reader.h ('k') | storage/browser/blob/blob_reader.cc » ('j') | no next file with comments »