Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2000483004: [BlobReader] Correct IsInMemory = false when async constructing (Closed)

Created:
4 years, 7 months ago by dmurph
Modified:
4 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BlobReader] Correct IsInMemory = false when async constructing BUG=611317 Committed: https://crrev.com/1f4afcf1730afbeaf79d6c115d8e92d7708da931 Cr-Commit-Position: refs/heads/master@{#395142}

Patch Set 1 #

Patch Set 2 : tests, and comment #

Patch Set 3 : tests, and comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M content/browser/blob_storage/blob_reader_unittest.cc View 1 2 8 chunks +8 lines, -1 line 0 comments Download
M net/base/upload_element_reader.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M storage/browser/blob/blob_reader.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M storage/browser/blob/blob_reader.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dmurph
Martin, Can you PTAL? This is to fix the attached bug. Daniel
4 years, 7 months ago (2016-05-20 17:48:21 UTC) #2
mmenke
Seems like we have some sort of integration test / layout test for this case. ...
4 years, 7 months ago (2016-05-20 17:52:30 UTC) #3
dmurph
Yeah, adding tests now. And whoops! Sorry, mixing all of my people up :0 On ...
4 years, 7 months ago (2016-05-20 17:53:46 UTC) #4
dmurph
Done, added tests and comment.
4 years, 7 months ago (2016-05-20 18:26:52 UTC) #5
mmenke
On 2016/05/20 18:26:52, dmurph wrote: > Done, added tests and comment. I'd suggest a more ...
4 years, 7 months ago (2016-05-20 18:35:54 UTC) #6
dmurph
On 2016/05/20 at 18:35:54, mmenke wrote: > On 2016/05/20 18:26:52, dmurph wrote: > > Done, ...
4 years, 7 months ago (2016-05-20 19:09:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000483004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000483004/40001
4 years, 7 months ago (2016-05-20 19:09:50 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-20 19:52:06 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 19:54:46 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1f4afcf1730afbeaf79d6c115d8e92d7708da931
Cr-Commit-Position: refs/heads/master@{#395142}

Powered by Google App Engine
This is Rietveld 408576698