Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000443002: Remove Release() from CXFA_FM2JSContext (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove Release() from CXFA_FM2JSContext BUG= Committed: https://pdfium.googlesource.com/pdfium/+/bc2f0c5c4e3bbb5f317c29716c2b94af03c38329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M xfa/fxfa/fm2js/xfa_fm2jsapi.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-19 22:30:21 UTC) #2
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-19 22:59:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000443002/1
4 years, 7 months ago (2016-05-19 23:01:58 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:17:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bc2f0c5c4e3bbb5f317c29716c2b94af03c3...

Powered by Google App Engine
This is Rietveld 408576698