Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: xfa/fxfa/fm2js/xfa_fm2jsapi.cpp

Issue 2000443002: Remove Release() from CXFA_FM2JSContext (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | xfa/fxfa/fm2js/xfa_fm2jscontext.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/fm2js/xfa_fm2jsapi.h" 7 #include "xfa/fxfa/fm2js/xfa_fm2jsapi.h"
8 8
9 #include "core/fxcrt/include/fx_basic.h" 9 #include "core/fxcrt/include/fx_basic.h"
10 #include "xfa/fxfa/fm2js/xfa_fm2jscontext.h" 10 #include "xfa/fxfa/fm2js/xfa_fm2jscontext.h"
(...skipping 21 matching lines...) Expand all
32 } 32 }
33 status = program.ParseProgram(); 33 status = program.ParseProgram();
34 if (status) { 34 if (status) {
35 wsError = program.GetError().message; 35 wsError = program.GetError().message;
36 return status; 36 return status;
37 } 37 }
38 program.TranslateProgram(wsJavascript); 38 program.TranslateProgram(wsJavascript);
39 return 0; 39 return 0;
40 } 40 }
41 XFA_HFM2JSCONTEXT XFA_FM2JS_ContextCreate() { 41 XFA_HFM2JSCONTEXT XFA_FM2JS_ContextCreate() {
42 return (XFA_HFM2JSCONTEXT)CXFA_FM2JSContext::Create(); 42 return reinterpret_cast<XFA_HFM2JSCONTEXT>(new CXFA_FM2JSContext);
43 } 43 }
44 void XFA_FM2JS_ContextInitialize(XFA_HFM2JSCONTEXT hFM2JSContext, 44 void XFA_FM2JS_ContextInitialize(XFA_HFM2JSCONTEXT hFM2JSContext,
45 FXJSE_HRUNTIME hScriptRuntime, 45 FXJSE_HRUNTIME hScriptRuntime,
46 FXJSE_HCONTEXT hScriptContext, 46 FXJSE_HCONTEXT hScriptContext,
47 CXFA_Document* pDocument) { 47 CXFA_Document* pDocument) {
48 CXFA_FM2JSContext* pContext = 48 CXFA_FM2JSContext* pContext =
49 reinterpret_cast<CXFA_FM2JSContext*>(hFM2JSContext); 49 reinterpret_cast<CXFA_FM2JSContext*>(hFM2JSContext);
50 pContext->Initialize(hScriptRuntime, hScriptContext, pDocument); 50 pContext->Initialize(hScriptRuntime, hScriptContext, pDocument);
51 } 51 }
52 void XFA_FM2JS_GlobalPropertyGetter(XFA_HFM2JSCONTEXT hFM2JSContext, 52 void XFA_FM2JS_GlobalPropertyGetter(XFA_HFM2JSCONTEXT hFM2JSContext,
53 FXJSE_HVALUE hValue) { 53 FXJSE_HVALUE hValue) {
54 CXFA_FM2JSContext* pContext = 54 CXFA_FM2JSContext* pContext =
55 reinterpret_cast<CXFA_FM2JSContext*>(hFM2JSContext); 55 reinterpret_cast<CXFA_FM2JSContext*>(hFM2JSContext);
56 pContext->GlobalPropertyGetter(hValue); 56 pContext->GlobalPropertyGetter(hValue);
57 } 57 }
58 void XFA_FM2JS_ContextRelease(XFA_HFM2JSCONTEXT hFM2JSContext) { 58 void XFA_FM2JS_ContextRelease(XFA_HFM2JSCONTEXT hFM2JSContext) {
59 CXFA_FM2JSContext* pContext = 59 delete reinterpret_cast<CXFA_FM2JSContext*>(hFM2JSContext);
60 reinterpret_cast<CXFA_FM2JSContext*>(hFM2JSContext);
61 pContext->Release();
62 } 60 }
63 #ifdef __cplusplus 61 #ifdef __cplusplus
64 } 62 }
65 #endif 63 #endif
OLDNEW
« no previous file with comments | « no previous file | xfa/fxfa/fm2js/xfa_fm2jscontext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698