Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000423006: Drop LABEL element from form-associated elements. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, kinuko+watch, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop LABEL element from form-associated elements. - Remove 'form' content attribute support from LABEL element - 'form' IDL attribute returns the value of label.control.form. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/QWyCpJjgfY8/TOxG9n-OAQAJ BUG=607868 Committed: https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be Cr-Commit-Position: refs/heads/master@{#396149}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -244 lines) Patch
D third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/form/test1.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/form/test1-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/label-formAssociatedElement.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/label-formAssociatedElement-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/form-associated-element.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/form-associated-element-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/form-attribute.html View 9 chunks +10 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/form-attribute-expected.txt View 4 chunks +7 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/form-attribute-nonexistence-form-id.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/form-attribute-nonexistence-form-id-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/form-control-infrastructure/form-expected.txt View 1 chunk +6 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-label-element/label-attributes-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/FormAssociatedElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/FormAssociatedElement.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.h View 3 chunks +6 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.cpp View 4 chunks +12 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTagNames.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/LabelsNodeList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLabelElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tkent
keishi, would you review this please?
4 years, 7 months ago (2016-05-26 07:37:30 UTC) #5
keishi
LGTM
4 years, 7 months ago (2016-05-26 07:43:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000423006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000423006/20001
4 years, 7 months ago (2016-05-26 08:25:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-26 08:30:37 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 08:32:11 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be
Cr-Commit-Position: refs/heads/master@{#396149}

Powered by Google App Engine
This is Rietveld 408576698