third_party/WebKit/Source/core/html/FormAssociatedElement.cpp - Issue 2000423006: Drop LABEL element from form-associated elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/FormAssociatedElement.cpp

Issue 2000423006: Drop LABEL element from form-associated elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/FormAssociatedElement.cpp

diff --git a/third_party/WebKit/Source/core/html/FormAssociatedElement.cpp b/third_party/WebKit/Source/core/html/FormAssociatedElement.cpp

index 27fd630314c71dbd4139fa0ffcf7272c11ec0aff..6a1245995269704d45767eae1df30f866584330a 100644

--- a/third_party/WebKit/Source/core/html/FormAssociatedElement.cpp

+++ b/third_party/WebKit/Source/core/html/FormAssociatedElement.cpp

@@ -29,7 +29,6 @@

#include "core/dom/NodeTraversal.h"

#include "core/html/HTMLFormControlElement.h"

#include "core/html/HTMLFormElement.h"

-#include "core/html/HTMLLabelElement.h"

#include "core/html/HTMLObjectElement.h"

#include "core/html/ValidityState.h"

@@ -311,8 +310,6 @@ const HTMLElement& toHTMLElement(const FormAssociatedElement& associatedElement)

{

if (associatedElement.isFormControlElement())

return toHTMLFormControlElement(associatedElement);

- if (associatedElement.isLabelElement())

- return toHTMLLabelElement(associatedElement);

return toHTMLObjectElement(associatedElement);

}