Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000323005: PDF: Use an empty password as a sentinel value for no password. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Use an empty password as a sentinel value for no password. Committed: https://crrev.com/5a6093c05d2cabb2aea6997b532ef2fe007ae177 Cr-Commit-Position: refs/heads/master@{#395767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -26 lines) Patch
M pdf/pdfium/pdfium_engine.h View 2 chunks +6 lines, -10 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 3 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
4 years, 7 months ago (2016-05-24 16:40:43 UTC) #2
raymes
lgtm
4 years, 7 months ago (2016-05-25 01:13:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000323005/1
4 years, 7 months ago (2016-05-25 01:21:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 01:26:44 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 01:28:39 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5a6093c05d2cabb2aea6997b532ef2fe007ae177
Cr-Commit-Position: refs/heads/master@{#395767}

Powered by Google App Engine
This is Rietveld 408576698