PDF: Use an empty password as a sentinel value for no password.

pdf/pdfium/pdfium_engine.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PDF_PDFIUM_PDFIUM_ENGINE_H_
 #define PDF_PDFIUM_PDFIUM_ENGINE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 186 matching lines @@
 
   // PDFium interface to request download of the block of data.
   static void AddSegment(FX_DOWNLOADHINTS* param,
                          size_t offset, size_t size);
 
   // We finished getting the pdf file, so load it. This will complete
   // asynchronously (due to password fetching) and may be run multiple times.
   void LoadDocument();
 
   // Try loading the document. Returns true if the document is successfully
-  // loaded or is already loaded otherwise it will return false. If
-  // |with_password| is set to true, the document will be loaded with
-  // |password|. If the document could not be loaded and needs a password,
-  // |needs_password| will be set to true.
-  bool TryLoadingDoc(bool with_password,
-                     const std::string& password,
-                     bool* needs_password);
+  // loaded or is already loaded otherwise it will return false. If there is a
+  // password, then |password| is non-empty. If the document could not be loaded
+  // and needs a password, |needs_password| will be set to true.
+  bool TryLoadingDoc(const std::string& password, bool* needs_password);
 
   // Ask the user for the document password and then continue loading the
   // document.
   void GetPasswordAndLoad();
 
   // Called when the password has been retrieved.
   void OnGetPasswordComplete(int32_t result,
                              const pp::Var& password);
 
   // Continues loading the document when the password has been retrieved, or if
-  // there is no password.
-  void ContinueLoadingDocument(bool has_password,
-                               const std::string& password);
+  // there is no password. If there is no password, then |password| is empty.
+  void ContinueLoadingDocument(const std::string& password);
 
   // Finish loading the document and notify the client that the document has
   // been loaded. This should only be run after |doc_| has been loaded and the
   // document is fully downloaded. If this has been run once, it will result in
   // a no-op.
   void FinishLoadingDocument();
 
   // Loads information about the pages in the document and calculate the
   // document size.
   void LoadPageInfo(bool reload);
@@ skipping 511 matching lines @@
   bool GetPDFPageSizeByIndex(const void* pdf_buffer,
                              int pdf_buffer_size,
                              int page_number,
                              double* width,
                              double* height) override;
 };
 
 }  // namespace chrome_pdf
 
 #endif  // PDF_PDFIUM_PDFIUM_ENGINE_H_