Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 200030: Show red/orange when shell or log steps fail/warn.... (Closed)

Created:
11 years, 3 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/master/
Visibility:
Public.

Description

Show red/orange when shell or log steps fail/warn. This cleans up a corner case where a shell step could fail, the log step warns, and the resulting box is shown orange (rather than red). BUG=18597 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M chromium_step.py View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
chase
11 years, 3 months ago (2009-09-05 00:33:02 UTC) #1
Nicolas Sylvain
11 years, 3 months ago (2009-09-07 00:38:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698