Show red/orange when shell or log steps fail/warn....

chromium_step.py

 #!/usr/bin/python
 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Subclasses of various slave command classes."""
 
 import copy
 import os
 
@@ skipping 108 matching lines @@
 
   def getText(self, cmd, results):
     text_list = self.describe(True)
     if self._result_text:
       self._result_text.insert(0, '<div class="BuildResultInfo">')
       self._result_text.append('</div>')
       text_list = text_list + self._result_text
     return text_list
 
   def evaluateCommand(self, cmd):
-    result = None
-
-    # If the log processor provides an evaluateCommand method, call it.
+    shell_result = shell.ShellCommand.evaluateCommand(self, cmd)
+    log_result = None
     if self._log_processor and 'evaluateCommand' in dir(self._log_processor):
-      result = self._log_processor.evaluateCommand(cmd)
-
-    if result is None or result is builder.SUCCESS:
-      # Report success of parent command.
-      result = shell.ShellCommand.evaluateCommand(self, cmd)
-
-    return result
+      log_result = self._log_processor.evaluateCommand(cmd)
+    if shell_result is builder.FAILURE or log_result is builder.FAILURE:
+      return builder.FAILURE
+    if shell_result is builder.WARNINGS or log_result is builder.WARNINGS:
+      return builder.WARNINGS
+    return builder.SUCCESS
 
   def _CreateReportLinkIfNeccessary(self):
     if self._log_processor.ReportLink():
       self.addURL('results', "%s" % self._log_processor.ReportLink())