Source/core/rendering/RenderLayer.cpp - Issue 200023002: Making LayoutUnit conversions to Float type explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 200023002: Making LayoutUnit conversions to Float type explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderLayer.cpp

diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp

index 02d27c174078b8931bc396cccfbad8239a448ef6..e58ca2fa873a9f2ce3970fff256a04d6e417f759 100644

--- a/Source/core/rendering/RenderLayer.cpp

+++ b/Source/core/rendering/RenderLayer.cpp

@@ -1063,8 +1063,7 @@ FloatPoint RenderLayer::perspectiveOrigin() const

const LayoutRect borderBox = toRenderBox(renderer())->borderBoxRect();

RenderStyle* style = renderer()->style();

- return FloatPoint(floatValueForLength(style->perspectiveOriginX(), borderBox.width()),

- floatValueForLength(style->perspectiveOriginY(), borderBox.height()));

+ return FloatPoint(floatValueForLength(style->perspectiveOriginX(), borderBox.width().toFloat()), floatValueForLength(style->perspectiveOriginY(), borderBox.height().toFloat()));

}

static inline bool isFixedPositionedContainer(RenderLayer* layer)

« Source/core/frame/FrameView.cpp ('K') | « Source/core/rendering/RenderBoxModelObject.cpp ('k') | Source/core/rendering/RenderMultiColumnSet.h » ('j') | Source/platform/LayoutUnit.h » ('J')