Source/core/rendering/RenderBoxModelObject.cpp - Issue 200023002: Making LayoutUnit conversions to Float type explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBoxModelObject.cpp

Issue 200023002: Making LayoutUnit conversions to Float type explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBoxModelObject.cpp

diff --git a/Source/core/rendering/RenderBoxModelObject.cpp b/Source/core/rendering/RenderBoxModelObject.cpp

index 6e65f69ea36471d80e30018b2115098f56be64ee..aea8ca512dcc403a40f197ecf9441750239ef4b2 100644

--- a/Source/core/rendering/RenderBoxModelObject.cpp

+++ b/Source/core/rendering/RenderBoxModelObject.cpp

@@ -2031,7 +2031,7 @@ void RenderBoxModelObject::clipBorderSidePolygon(GraphicsContext* graphicsContex

const LayoutRect& outerRect = outerBorder.rect();

const LayoutRect& innerRect = innerBorder.rect();

- FloatPoint centerPoint(innerRect.location().x() + static_cast<float>(innerRect.width()) / 2, innerRect.location().y() + static_cast<float>(innerRect.height()) / 2);

+ FloatPoint centerPoint(innerRect.location().x().toFloat() + innerRect.width().toFloat() / 2, innerRect.location().y().toFloat() + innerRect.height().toFloat() / 2);

// For each side, create a quad that encompasses all parts of that side that may draw,

// including areas inside the innerBorder.

« Source/core/frame/FrameView.cpp ('K') | « Source/core/rendering/RenderBlockFlow.cpp ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | Source/platform/LayoutUnit.h » ('J')