Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: Source/core/dom/Document.cpp

Issue 200023002: Making LayoutUnit conversions to Float type explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index f12e57867810d217ab1d1453594fd8c6fa8c2af4..6866b423ba68e59e1a49ea49b8b986723700d4ff 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -5107,7 +5107,7 @@ void Document::adjustFloatQuadsForScrollAndAbsoluteZoom(Vector<FloatQuad>& quads
LayoutRect visibleContentRect = view()->visibleContentRect();
for (size_t i = 0; i < quads.size(); ++i) {
- quads[i].move(-FloatSize(visibleContentRect.x(), visibleContentRect.y()));
+ quads[i].move(-FloatSize(visibleContentRect.x().toFloat(), visibleContentRect.y().toFloat()));
leviw_travelin_and_unemployed 2014/03/14 18:25:26 It'd be nice to use visibleContentRect.location()
gnana 2014/03/18 14:20:18 We have below canditates for move FloatQuad::Move(
adjustFloatQuadForAbsoluteZoom(quads[i], renderer);
}
}
@@ -5118,7 +5118,7 @@ void Document::adjustFloatRectForScrollAndAbsoluteZoom(FloatRect& rect, RenderOb
return;
LayoutRect visibleContentRect = view()->visibleContentRect();
- rect.move(-FloatSize(visibleContentRect.x(), visibleContentRect.y()));
+ rect.move(-FloatSize(visibleContentRect.x().toFloat(), visibleContentRect.y().toFloat()));
leviw_travelin_and_unemployed 2014/03/14 18:25:26 Ditto.
gnana 2014/03/18 14:20:18 We have below canditates for move FloatQuad::Move(
adjustFloatRectForAbsoluteZoom(rect, renderer);
}

Powered by Google App Engine
This is Rietveld 408576698