Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 200023002: Making LayoutUnit conversions to Float type explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5089 matching lines...) Expand 10 before | Expand all | Expand 10 after
5100 return node; 5100 return node;
5101 } 5101 }
5102 5102
5103 void Document::adjustFloatQuadsForScrollAndAbsoluteZoom(Vector<FloatQuad>& quads , RenderObject& renderer) 5103 void Document::adjustFloatQuadsForScrollAndAbsoluteZoom(Vector<FloatQuad>& quads , RenderObject& renderer)
5104 { 5104 {
5105 if (!view()) 5105 if (!view())
5106 return; 5106 return;
5107 5107
5108 LayoutRect visibleContentRect = view()->visibleContentRect(); 5108 LayoutRect visibleContentRect = view()->visibleContentRect();
5109 for (size_t i = 0; i < quads.size(); ++i) { 5109 for (size_t i = 0; i < quads.size(); ++i) {
5110 quads[i].move(-FloatSize(visibleContentRect.x(), visibleContentRect.y()) ); 5110 quads[i].move(-FloatSize(visibleContentRect.x().toFloat(), visibleConten tRect.y().toFloat()));
leviw_travelin_and_unemployed 2014/03/14 18:25:26 It'd be nice to use visibleContentRect.location()
gnana 2014/03/18 14:20:18 We have below canditates for move FloatQuad::Move(
5111 adjustFloatQuadForAbsoluteZoom(quads[i], renderer); 5111 adjustFloatQuadForAbsoluteZoom(quads[i], renderer);
5112 } 5112 }
5113 } 5113 }
5114 5114
5115 void Document::adjustFloatRectForScrollAndAbsoluteZoom(FloatRect& rect, RenderOb ject& renderer) 5115 void Document::adjustFloatRectForScrollAndAbsoluteZoom(FloatRect& rect, RenderOb ject& renderer)
5116 { 5116 {
5117 if (!view()) 5117 if (!view())
5118 return; 5118 return;
5119 5119
5120 LayoutRect visibleContentRect = view()->visibleContentRect(); 5120 LayoutRect visibleContentRect = view()->visibleContentRect();
5121 rect.move(-FloatSize(visibleContentRect.x(), visibleContentRect.y())); 5121 rect.move(-FloatSize(visibleContentRect.x().toFloat(), visibleContentRect.y( ).toFloat()));
leviw_travelin_and_unemployed 2014/03/14 18:25:26 Ditto.
gnana 2014/03/18 14:20:18 We have below canditates for move FloatQuad::Move(
5122 adjustFloatRectForAbsoluteZoom(rect, renderer); 5122 adjustFloatRectForAbsoluteZoom(rect, renderer);
5123 } 5123 }
5124 5124
5125 bool Document::hasActiveParser() 5125 bool Document::hasActiveParser()
5126 { 5126 {
5127 return m_activeParserCount || (m_parser && m_parser->processingData()); 5127 return m_activeParserCount || (m_parser && m_parser->processingData());
5128 } 5128 }
5129 5129
5130 void Document::decrementActiveParserCount() 5130 void Document::decrementActiveParserCount()
5131 { 5131 {
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
5484 } 5484 }
5485 5485
5486 void Document::invalidateNodeListCaches(const QualifiedName* attrName) 5486 void Document::invalidateNodeListCaches(const QualifiedName* attrName)
5487 { 5487 {
5488 HashSet<LiveNodeListBase*>::iterator end = m_listsInvalidatedAtDocument.end( ); 5488 HashSet<LiveNodeListBase*>::iterator end = m_listsInvalidatedAtDocument.end( );
5489 for (HashSet<LiveNodeListBase*>::iterator it = m_listsInvalidatedAtDocument. begin(); it != end; ++it) 5489 for (HashSet<LiveNodeListBase*>::iterator it = m_listsInvalidatedAtDocument. begin(); it != end; ++it)
5490 (*it)->invalidateCache(attrName); 5490 (*it)->invalidateCache(attrName);
5491 } 5491 }
5492 5492
5493 } // namespace WebCore 5493 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698