Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2000203002: [Interpreter] Fix getIgnitionDispatchCounters crash with modified Object prototype. (Closed)

Created:
4 years, 7 months ago by Stefano Sanfilippo
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix getIgnitionDispatchCounters crash with modified Object prototype. Changes to the Object prototype may cause getIgnitionDispatchCounters() to fail when building the counters table object. Using DefineOwnProperty instead of Set solves the issue by ignoring the prototype chain. BUG=chromium:613567 LOG=N Committed: https://crrev.com/26569a47d156cc24b39083ce924daa4674c12042 Cr-Commit-Position: refs/heads/master@{#36447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/interpreter/interpreter.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Stefano Sanfilippo
This fixes Chromium issue 613567. An unhandled exception is still reported by d8, but it ...
4 years, 7 months ago (2016-05-23 15:51:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000203002/1
4 years, 7 months ago (2016-05-23 15:52:04 UTC) #4
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-23 16:08:25 UTC) #6
rmcilroy
LGTM, thanks.
4 years, 7 months ago (2016-05-23 16:12:58 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 16:26:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000203002/1
4 years, 7 months ago (2016-05-23 16:38:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 16:40:07 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 16:41:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26569a47d156cc24b39083ce924daa4674c12042
Cr-Commit-Position: refs/heads/master@{#36447}

Powered by Google App Engine
This is Rietveld 408576698