Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: src/interpreter/interpreter.cc

Issue 2000203002: [Interpreter] Fix getIgnitionDispatchCounters crash with modified Object prototype. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter.cc
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
index 49152a2022e3b45a6f6848d7c84260b006130bed..f5386bcbd26455bb787027e6dead15c71ad19b7c 100644
--- a/src/interpreter/interpreter.cc
+++ b/src/interpreter/interpreter.cc
@@ -250,7 +250,8 @@ Local<v8::Object> Interpreter::GetDispatchCountersObject() {
NewStringType::kNormal)
.ToLocalChecked();
Local<v8::Number> counter_object = v8::Number::New(isolate, counter);
- CHECK(counters_row->Set(context, to_name_object, counter_object)
+ CHECK(counters_row
+ ->DefineOwnProperty(context, to_name_object, counter_object)
.IsJust());
}
}
@@ -261,7 +262,9 @@ Local<v8::Object> Interpreter::GetDispatchCountersObject() {
NewStringType::kNormal)
.ToLocalChecked();
- CHECK(counters_map->Set(context, from_name_object, counters_row).IsJust());
+ CHECK(
+ counters_map->DefineOwnProperty(context, from_name_object, counters_row)
+ .IsJust());
}
return counters_map;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698