Clean up more XFA code which causes warnings

Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
Most of them will have behavior change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
  Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29
Committed: https://pdfium.googlesource.com/pdfium/+/524fa626d71efeb2164c82d565f17f077035b7df

[Wei Li, 2016-05-23 16:30:18]

Description was changed from

==========
Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
All of them except one will have different behavior after the change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
  Unnecessary condition

xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
  xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code

xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29
==========

to

==========
Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
All of them except one will have different behavior after the change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
  Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
  xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29
==========

[Wei Li, 2016-05-23 16:32:23]

Description was changed from

==========
Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
All of them except one will have different behavior after the change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
  Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
  xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29
==========

to

==========
Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
All of them except one will have different behavior after the change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
  Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29
==========

[Wei Li, 2016-05-23 16:33:17]

Description was changed from

==========
Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
All of them except one will have different behavior after the change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
  Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29
==========

to

==========
Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
Most of them will have behavior change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
  Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29
==========

[Wei Li, 2016-05-23 16:33:54]

weili@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[Wei Li, 2016-05-23 16:33:54]

for review, thanks

[Tom Sepez, 2016-05-23 16:57:54]

lgtm

https://codereview.chromium.org/2000073003/diff/1/xfa/fgas/localization/fgas_...
File xfa/fgas/localization/fgas_locale.cpp (right):

https://codereview.chromium.org/2000073003/diff/1/xfa/fgas/localization/fgas_...
xfa/fgas/localization/fgas_locale.cpp:3658: if (cc < cc_start + 3)
wow ... was there some compiler smart enough to know that this would always be <
1000?

https://codereview.chromium.org/2000073003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
File xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp (right):

https://codereview.chromium.org/2000073003/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp:429: e = BCExceptionNO;
agreed, most likely this was the intent.

https://codereview.chromium.org/2000073003/diff/1/xfa/fxfa/app/xfa_fffield.cpp
File xfa/fxfa/app/xfa_fffield.cpp (left):

https://codereview.chromium.org/2000073003/diff/1/xfa/fxfa/app/xfa_fffield.cp...
xfa/fxfa/app/xfa_fffield.cpp:453: return FALSE;
hahahaha

[Wei Li, 2016-05-23 17:10:44]

thanks for the review

https://codereview.chromium.org/2000073003/diff/1/xfa/fgas/localization/fgas_...
File xfa/fgas/localization/fgas_locale.cpp (right):

https://codereview.chromium.org/2000073003/diff/1/xfa/fgas/localization/fgas_...
xfa/fgas/localization/fgas_locale.cpp:3658: if (cc < cc_start + 3)
On 2016/05/23 16:57:54, Tom Sepez wrote:
> wow ... was there some compiler smart enough to know that this would always be
<
> 1000?

Yes, GCC wants to optimize this away. It is not that easy to figure this out :)

[Wei Li, 2016-05-23 17:11:34]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-05-23 17:11:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000073003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000073003/1

[commit-bot: I haz the power, 2016-05-23 17:38:10]

Description was changed from

==========
Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
Most of them will have behavior change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
  Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29
==========

to

==========
Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
Most of them will have behavior change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
  Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29

Committed:
https://pdfium.googlesource.com/pdfium/+/524fa626d71efeb2164c82d565f17f077035...
==========

[commit-bot: I haz the power, 2016-05-23 17:38:11]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/524fa626d71efeb2164c82d565f17f077035...