Clean up more XFA code which causes warnings

xfa/fxbarcode/qrcode/BC_QRDetector.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2007 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 38 matching lines @@
 CBC_QRDetectorResult* CBC_QRDetector::ProcessFinderPatternInfo(
     CBC_QRFinderPatternInfo* info,
     int32_t& e) {
   std::unique_ptr<CBC_QRFinderPattern> topLeft(info->GetTopLeft());
   std::unique_ptr<CBC_QRFinderPattern> topRight(info->GetTopRight());
   std::unique_ptr<CBC_QRFinderPattern> bottomLeft(info->GetBottomLeft());
   FX_FLOAT moduleSize =
       CalculateModuleSize(topLeft.get(), topRight.get(), bottomLeft.get());
   if (moduleSize < 1.0f) {
     e = BCExceptionRead;
-    BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
+    return nullptr;
   }
   int32_t dimension = ComputeDimension(topLeft.get(), topRight.get(),
                                        bottomLeft.get(), moduleSize, e);
-  BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
+  BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);
   CBC_QRCoderVersion* provisionalVersion =
       CBC_QRCoderVersion::GetProvisionalVersionForDimension(dimension, e);
-  BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
+  BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);
   int32_t modulesBetweenFPCenters =
       provisionalVersion->GetDimensionForVersion() - 7;
-  CBC_QRAlignmentPattern* alignmentPattern = NULL;
+  CBC_QRAlignmentPattern* alignmentPattern = nullptr;
   if (provisionalVersion->GetAlignmentPatternCenters()->GetSize() > 0) {
     FX_FLOAT bottomRightX =
         topRight->GetX() - topLeft->GetX() + bottomLeft->GetX();
     FX_FLOAT bottomRightY =
         topRight->GetY() - topLeft->GetY() + bottomLeft->GetY();
     FX_FLOAT correctionToTopLeft =
         1.0f - 3.0f / (FX_FLOAT)modulesBetweenFPCenters;
     FX_FLOAT xtemp = (topLeft->GetX() +
                       correctionToTopLeft * (bottomRightX - topLeft->GetX()));
     int32_t estAlignmentX = (int32_t)xtemp;
     FX_FLOAT ytemp = (topLeft->GetY() +
                       correctionToTopLeft * (bottomRightY - topLeft->GetY()));
     int32_t estAlignmentY = (int32_t)ytemp;
     for (int32_t i = 4; i <= 16; i <<= 1) {
       CBC_QRAlignmentPattern* temp = FindAlignmentInRegion(
           moduleSize, estAlignmentX, estAlignmentY, (FX_FLOAT)i, e);
-      alignmentPattern = temp;
-      break;
+      if (temp) {
+        alignmentPattern = temp;
+        break;
+      }
     }
   }
   CBC_CommonBitMatrix* bits =
       SampleGrid(m_image, topLeft.get(), topRight.get(), bottomLeft.get(),
                  (CBC_ResultPoint*)(alignmentPattern), dimension, e);
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
 
   CFX_ArrayTemplate<CBC_ResultPoint*>* points =
       new CFX_ArrayTemplate<CBC_ResultPoint*>();
   points->Add(bottomLeft.release());
@@ skipping 169 matching lines @@
   int32_t alignmentAreaBottomY =
       std::min(m_image->GetHeight() - 1, estAlignmentY + allowance);
   CBC_QRAlignmentPatternFinder alignmentFinder(
       m_image, alignmentAreaLeftX, alignmentAreaTopY,
       alignmentAreaRightX - alignmentAreaLeftX,
       alignmentAreaBottomY - alignmentAreaTopY, overallEstModuleSize);
   CBC_QRAlignmentPattern* qap = alignmentFinder.Find(e);
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
   return qap;
 }