tracing/tracing/metrics/system_health/memory_metric_test.html - Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/memory_metric_test.html

Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/metrics/system_health/memory_metric.html ('k') | tracing/tracing/metrics/system_health/power_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/system_health/memory_metric_test.html

diff --git a/tracing/tracing/metrics/system_health/memory_metric_test.html b/tracing/tracing/metrics/system_health/memory_metric_test.html

index b499ccbc54fff8842120208a3fef7082b036811b..a2a5a7c93a7b623d236ef9ed0bb40e4c05ff7b1a 100644

--- a/tracing/tracing/metrics/system_health/memory_metric_test.html

+++ b/tracing/tracing/metrics/system_health/memory_metric_test.html

@@ -36,7 +36,6 @@ tr.b.unittest.testSuite(function() {

test(name, function() {

// Create a model and a fake value list.

var model = tr.c.TestUtils.newModel(modelCallback);

- model.canonicalUrl = 'memory://metric.test.com';

var valueNameToValues = {};

var fakeValueList = {

addValue: function(value) {

@@ -71,8 +70,6 @@ tr.b.unittest.testSuite(function() {

'Multiple \'' + valueName + '\' values');

var actualValue = actualValues[0];

assert.instanceOf(actualValue, tr.v.NumericValue);

- assert.strictEqual(actualValue.canonicalUrl,

- 'memory://metric.test.com');

var actualNumeric = actualValue.numeric;

var expectedNumeric = expectedNumerics[valueName];