tracing/tracing/metrics/system_health/memory_metric.html - Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/memory_metric.html

Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/metrics/system_health/hazard_metric_test.html ('k') | tracing/tracing/metrics/system_health/memory_metric_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/system_health/memory_metric.html

diff --git a/tracing/tracing/metrics/system_health/memory_metric.html b/tracing/tracing/metrics/system_health/memory_metric.html

index f581c1b65f52ea9c23af79eeb0351d4b6fdf5a83..9ae461857242c32f24d5a7b8c7fd91275e638e12 100644

--- a/tracing/tracing/metrics/system_health/memory_metric.html

+++ b/tracing/tracing/metrics/system_health/memory_metric.html

@@ -424,7 +424,6 @@ tr.exportTo('tr.metrics.sh', function() {

'to the trace'

].join(' ');

values.addValue(new tr.v.NumericValue(

- model.canonicalUrl,

['memory', browserName, ALL_PROCESS_NAMES, 'dump_count',

levelOfDetailName].join(':'),

new ScalarNumeric(

@@ -643,7 +642,6 @@ tr.exportTo('tr.metrics.sh', function() {

browserUserFriendlyName

].join(' ');

values.addValue(new tr.v.NumericValue(

- model.canonicalUrl,

['memory', browserName, processName, valueName].join(':'),

buildMemoryNumeric(timeToSum, valueSpec.unit),

{ description: description }));