Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: tracing/tracing/metrics/metric_registry_test.html

Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/metric_map_function_test.html ('k') | tracing/tracing/metrics/sample_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/metric_registry_test.html
diff --git a/tracing/tracing/metrics/metric_registry_test.html b/tracing/tracing/metrics/metric_registry_test.html
index 1e56212435f09e2ea40c232fee089e503a542b9f..21a3584a3ab21df7c38ffae7f155d1dad919f0d4 100644
--- a/tracing/tracing/metrics/metric_registry_test.html
+++ b/tracing/tracing/metrics/metric_registry_test.html
@@ -21,8 +21,7 @@ tr.b.unittest.testSuite(function() {
function sampleMetricA(values, model) {
var unit = tr.v.Unit.byName.sizeInBytes_smallerIsBetter;
var n1 = new tr.v.ScalarNumeric(unit, 1);
- values.addValue(new tr.v.NumericValue(
- model.canonicalUrl, 'foo', n1));
+ values.addValue(new tr.v.NumericValue('foo', n1));
}
tr.metrics.MetricRegistry.register(sampleMetricA);
@@ -30,10 +29,8 @@ tr.b.unittest.testSuite(function() {
var unit = tr.v.Unit.byName.sizeInBytes_smallerIsBetter;
var n1 = new tr.v.ScalarNumeric(unit, 1);
var n2 = new tr.v.ScalarNumeric(unit, 2);
- values.addValue(new tr.v.NumericValue(
- model.canonicalUrl, 'foo', n1));
- values.addValue(new tr.v.NumericValue(
- model.canonicalUrl, 'bar', n2));
+ values.addValue(new tr.v.NumericValue('foo', n1));
+ values.addValue(new tr.v.NumericValue('bar', n2));
}
tr.metrics.MetricRegistry.register(sampleMetricB);
@@ -42,12 +39,9 @@ tr.b.unittest.testSuite(function() {
var n1 = new tr.v.ScalarNumeric(unit, 1);
var n2 = new tr.v.ScalarNumeric(unit, 2);
var n3 = new tr.v.ScalarNumeric(unit, 3);
- values.addValue(new tr.v.NumericValue(
- model.canonicalUrl, 'foo', n1));
- values.addValue(new tr.v.NumericValue(
- model.canonicalUrl, 'bar', n2));
- values.addValue(new tr.v.NumericValue(
- model.canonicalUrl, 'baz', n3));
+ values.addValue(new tr.v.NumericValue('foo', n1));
+ values.addValue(new tr.v.NumericValue('bar', n2));
+ values.addValue(new tr.v.NumericValue('baz', n3));
}
tr.metrics.MetricRegistry.register(sampleMetricC);
« no previous file with comments | « tracing/tracing/metrics/metric_map_function_test.html ('k') | tracing/tracing/metrics/sample_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698