Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1999813002: Revert of media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros (Closed)

Created:
4 years, 7 months ago by gogerald1
Modified:
4 years, 7 months ago
Reviewers:
Srirama, fs
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros (patchset #3 id:40001 of https://codereview.chromium.org/2003543002/ ) Reason for revert: Crash build http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/44237. https://chromium.googlesource.com/chromium/src/+blame/master/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp#783 DCHECKs are removed from Release build. Original issue's description: > media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros > > Replaced wtf/Assertions.h macros in favor of base/logging.h > macros in core/html/track folder. > > ASSERT, ASSERT_UNUSED -> DCHECK > ASSERT_NOT_REACHED -> NOTREACHED > ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK > > BUG=596522 > > Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515 > Cr-Commit-Position: refs/heads/master@{#395078} TBR=fs@opera.com,srirama.m@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596522 Committed: https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d Cr-Commit-Position: refs/heads/master@{#395080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -94 lines) Patch
M third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/CueTimeline.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/CueTimeline.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 8 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackList.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackListBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/VideoTrackList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp View 19 chunks +24 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
gogerald1
Created Revert of media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros
4 years, 7 months ago (2016-05-20 16:06:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999813002/1
4 years, 7 months ago (2016-05-20 16:07:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 16:07:56 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 16:09:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d
Cr-Commit-Position: refs/heads/master@{#395080}

Powered by Google App Engine
This is Rietveld 408576698