third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp - Issue 1999813002: Revert of media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

Issue 1999813002: Revert of media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/CueTimeline.cpp ('k') | third_party/WebKit/Source/core/html/track/TextTrack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

diff --git a/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp b/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

index f9125f11ffbe9738dd857221e3627c0248c22fee..78cb2b7acb87945e1617735e8350e11fa85c25b1 100644

--- a/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

+++ b/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

@@ -54,7 +54,7 @@

default:

break;

}

- NOTREACHED();

+ ASSERT_NOT_REACHED();

return TextTrack::subtitlesKeyword();

}

@@ -84,7 +84,7 @@

if (trackList)

return;

- DCHECK(m_webTrack);

+ ASSERT(m_webTrack);

m_webTrack->setClient(nullptr);

m_webTrack = nullptr;

}

@@ -92,7 +92,7 @@

void InbandTextTrack::addWebVTTCue(double start, double end, const WebString& id, const WebString& content, const WebString& settings)

{

HTMLMediaElement* owner = mediaElement();

- DCHECK(owner);

+ ASSERT(owner);

VTTCue* cue = VTTCue::create(owner->document(), start, end, content);

cue->setId(id);

cue->parseSettings(settings);