third_party/WebKit/Source/core/loader/NavigationScheduler.cpp - Issue 1999573003: OOPIFs: Fixing submitting forms targeting a remote frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

Issue 1999573003: OOPIFs: Fixing submitting forms targeting a remote frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@form-target-is-cross-site-frame

Patch Set: Added a TODO for investigating if remote and local frames can be handled uniformly. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

diff --git a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

index f1fc9b375d8d6094c7182dab8033be41be349836..bbb14295b3fe3bd628c879cd079b6e42f0622320 100644

--- a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

+++ b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

@@ -276,11 +276,8 @@ public:

void fire(LocalFrame* frame) override

{

OwnPtr<UserGestureIndicator> gestureIndicator = createUserGestureIndicator();

- FrameLoadRequest frameRequest(originDocument());

- m_submission->populateFrameLoadRequest(frameRequest);

+ FrameLoadRequest frameRequest = m_submission->createFrameLoadRequest(originDocument());

frameRequest.setReplacesCurrentItem(replacesCurrentItem());

- frameRequest.setTriggeringEvent(m_submission->event());

- frameRequest.setForm(m_submission->form());

maybeLogScheduledNavigationClobber(ScheduledNavigationType::ScheduledFormSubmission, frame, frameRequest, gestureIndicator.get());

frame->loader().load(frameRequest);

}

« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »