Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

Issue 1999573003: OOPIFs: Fixing submitting forms targeting a remote frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@form-target-is-cross-site-frame
Patch Set: Added a TODO for investigating if remote and local frames can be handled uniformly. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 4 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
5 * Copyright (C) 2009 Adam Barth. All rights reserved. 5 * Copyright (C) 2009 Adam Barth. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 10 *
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 class ScheduledFormSubmission final : public ScheduledNavigation { 269 class ScheduledFormSubmission final : public ScheduledNavigation {
270 public: 270 public:
271 static ScheduledFormSubmission* create(Document* document, FormSubmission* s ubmission, bool replacesCurrentItem) 271 static ScheduledFormSubmission* create(Document* document, FormSubmission* s ubmission, bool replacesCurrentItem)
272 { 272 {
273 return new ScheduledFormSubmission(document, submission, replacesCurrent Item); 273 return new ScheduledFormSubmission(document, submission, replacesCurrent Item);
274 } 274 }
275 275
276 void fire(LocalFrame* frame) override 276 void fire(LocalFrame* frame) override
277 { 277 {
278 OwnPtr<UserGestureIndicator> gestureIndicator = createUserGestureIndicat or(); 278 OwnPtr<UserGestureIndicator> gestureIndicator = createUserGestureIndicat or();
279 FrameLoadRequest frameRequest(originDocument()); 279 FrameLoadRequest frameRequest = m_submission->createFrameLoadRequest(ori ginDocument());
280 m_submission->populateFrameLoadRequest(frameRequest);
281 frameRequest.setReplacesCurrentItem(replacesCurrentItem()); 280 frameRequest.setReplacesCurrentItem(replacesCurrentItem());
282 frameRequest.setTriggeringEvent(m_submission->event());
283 frameRequest.setForm(m_submission->form());
284 maybeLogScheduledNavigationClobber(ScheduledNavigationType::ScheduledFor mSubmission, frame, frameRequest, gestureIndicator.get()); 281 maybeLogScheduledNavigationClobber(ScheduledNavigationType::ScheduledFor mSubmission, frame, frameRequest, gestureIndicator.get());
285 frame->loader().load(frameRequest); 282 frame->loader().load(frameRequest);
286 } 283 }
287 284
288 DEFINE_INLINE_VIRTUAL_TRACE() 285 DEFINE_INLINE_VIRTUAL_TRACE()
289 { 286 {
290 visitor->trace(m_submission); 287 visitor->trace(m_submission);
291 ScheduledNavigation::trace(visitor); 288 ScheduledNavigation::trace(visitor);
292 } 289 }
293 290
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 m_redirect.clear(); 492 m_redirect.clear();
496 } 493 }
497 494
498 DEFINE_TRACE(NavigationScheduler) 495 DEFINE_TRACE(NavigationScheduler)
499 { 496 {
500 visitor->trace(m_frame); 497 visitor->trace(m_frame);
501 visitor->trace(m_redirect); 498 visitor->trace(m_redirect);
502 } 499 }
503 500
504 } // namespace blink 501 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698