Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: third_party/WebKit/Source/core/loader/FormSubmission.h

Issue 1999573003: OOPIFs: Fixing submitting forms targeting a remote frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@form-target-is-cross-site-frame
Patch Set: Added a TODO for investigating if remote and local frames can be handled uniformly. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FormSubmission.h
diff --git a/third_party/WebKit/Source/core/loader/FormSubmission.h b/third_party/WebKit/Source/core/loader/FormSubmission.h
index 36e3ec76e2c5ff03c9ca6bbdb8574aab4dfa9f1a..97e1009366154d09f5363205c0f7a2300257e52b 100644
--- a/third_party/WebKit/Source/core/loader/FormSubmission.h
+++ b/third_party/WebKit/Source/core/loader/FormSubmission.h
@@ -31,6 +31,7 @@
#ifndef FormSubmission_h
#define FormSubmission_h
+#include "core/loader/FrameLoadRequest.h"
#include "platform/heap/Handle.h"
#include "platform/weborigin/KURL.h"
#include "platform/weborigin/Referrer.h"
@@ -38,9 +39,9 @@
namespace blink {
+class Document;
class EncodedFormData;
class Event;
-struct FrameLoadRequest;
class HTMLFormElement;
class FormSubmission : public GarbageCollectedFinalized<FormSubmission> {
@@ -92,7 +93,7 @@ public:
static FormSubmission* create(HTMLFormElement*, const Attributes&, Event*);
DECLARE_TRACE();
- void populateFrameLoadRequest(FrameLoadRequest&);
+ FrameLoadRequest createFrameLoadRequest(Document* originDocument);
KURL requestURL() const;
@@ -102,7 +103,6 @@ public:
void clearTarget() { m_target = nullAtom; }
HTMLFormElement* form() const { return m_form.get(); }
EncodedFormData* data() const { return m_formData.get(); }
- Event* event() const { return m_event.get(); }
const String& result() const { return m_result; }
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormElement.cpp ('k') | third_party/WebKit/Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698