Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: third_party/WebKit/Source/core/loader/FormSubmission.cpp

Issue 1999573003: OOPIFs: Fixing submitting forms targeting a remote frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@form-target-is-cross-site-frame
Patch Set: Added a TODO for investigating if remote and local frames can be handled uniformly. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FormSubmission.cpp
diff --git a/third_party/WebKit/Source/core/loader/FormSubmission.cpp b/third_party/WebKit/Source/core/loader/FormSubmission.cpp
index 3d19b0fc6f2e7387b9496ff344fb37a40b639c51..de7831e1164a44d7164080ed4008675ffb32e21b 100644
--- a/third_party/WebKit/Source/core/loader/FormSubmission.cpp
+++ b/third_party/WebKit/Source/core/loader/FormSubmission.cpp
@@ -271,8 +271,10 @@ KURL FormSubmission::requestURL() const
return requestURL;
}
-void FormSubmission::populateFrameLoadRequest(FrameLoadRequest& frameRequest)
+FrameLoadRequest FormSubmission::createFrameLoadRequest(Document* originDocument)
{
+ FrameLoadRequest frameRequest(originDocument);
+
if (!m_target.isEmpty())
frameRequest.setFrameName(m_target);
@@ -288,6 +290,11 @@ void FormSubmission::populateFrameLoadRequest(FrameLoadRequest& frameRequest)
}
frameRequest.resourceRequest().setURL(requestURL());
+
+ frameRequest.setTriggeringEvent(m_event);
+ frameRequest.setForm(m_form);
+
+ return frameRequest;
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/loader/FormSubmission.h ('k') | third_party/WebKit/Source/core/loader/FrameLoadRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698