Issue 1999043002: VM: Fix bug that can causes infinite opt/deopt loop.

Issue 1999043002: VM: Fix bug that can causes infinite opt/deopt loop. (Closed)

Created:
4 years, 7 months ago by Florian Schneider

Modified:
4 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix bug that can causes infinite opt/deopt loop. When deoptimizing on a hoisted TestCids instruction, we must mark the function to that this instruction does not get hoisted the next time the function gets optimized. BUG=dartbug.com/26500 R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/baaea63e0a4b0e18dc423f967920b0bd42b5ea8a

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -13 lines)			Patch
M	runtime/vm/intermediate_language.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/redundancy_elimination.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 7 months ago (2016-05-20 11:43:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
baaea63e0a4b0e18dc423f967920b0bd42b5ea8a (presubmit successful).