runtime/vm/redundancy_elimination.cc - Issue 1999043002: VM: Fix bug that can causes infinite opt/deopt loop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/redundancy_elimination.cc

Issue 1999043002: VM: Fix bug that can causes infinite opt/deopt loop. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/redundancy_elimination.cc

diff --git a/runtime/vm/redundancy_elimination.cc b/runtime/vm/redundancy_elimination.cc

index adc131995d27c87fd9ca5f9c5cdd683056dbd1af..4b8b3bf7da7ff10c7cc723de7a50b421db69dd51 100644

--- a/runtime/vm/redundancy_elimination.cc

+++ b/runtime/vm/redundancy_elimination.cc

@@ -1353,6 +1353,8 @@ void LICM::Hoist(ForwardInstructionIterator* it,

current->AsCheckEitherNonSmi()->set_licm_hoisted(true);

} else if (current->IsCheckArrayBound()) {

current->AsCheckArrayBound()->set_licm_hoisted(true);

+ } else if (current->IsTestCids()) {

+ current->AsTestCids()->set_licm_hoisted(true);

}

if (FLAG_trace_optimization) {

THR_Print("Hoisting instruction %s:%" Pd " from B%" Pd " to B%" Pd "\n",

« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »