Issue 19990004: [VS Addin] Don't fail installation if win32 platform is missing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19990004: [VS Addin] Don't fail installation if win32 platform is missing. (Closed)

Created:
7 years, 5 months ago by Sam Clegg

Modified:
7 years, 4 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

[VS Addin] Don't fail installation if win32 platform is missing. It seems that it is possible to install VS with only x86 and not win32 platforms. In this case we can't install the PPAPI platform (as it is a clone of win32) but we should probably not fail the installation completely. Also, handle errors from create_ppapi_platform more gracefully. R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1564

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	visual_studio/NativeClientVSAddIn/InstallerResources/install.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

7 years, 4 months ago (2013-07-30 21:52:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1564 (presubmit successful).

Expand Messages | Collapse Messages