visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py - Issue 19990004: [VS Addin] Don't fail installation if win32 platform is missing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py

Issue 19990004: [VS Addin] Don't fail installation if win32 platform is missing. (Closed) Base URL: https://nativeclient-sdk.googlecode.com/svn/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py

diff --git a/visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py b/visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py

index 093dfb80d13be6aaee6a540f8760476b82925a3c..52641336866291aaecb1882fe99cf77fcd36ecfb 100644

--- a/visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py

+++ b/visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py

@@ -178,7 +178,9 @@ def CreatePPAPIPlatform(install_dir):

patch_dir = os.path.join(SCRIPT_DIR, 'PPAPI_Patch')

if not os.path.exists(win32_dir):

- raise Error('Win32 MSBuild directory not found: %s' % win32_dir)

+ print 'Win32 MSBuild directory not found: %s' % win32_dir

+ print 'Skipping PPAPI platform install.'

+ return

print "Cloning Win32 platform from: %s" % win32_dir

« no previous file with comments | « no previous file | visual_studio/NativeClientVSAddIn/InstallerResources/install.py » ('j') | no next file with comments »