Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc
diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc
index 1024346c283c0016122d9d2dd789b046b34a27b2..ba029faae8b36c622023260c8ab4fe777ca37f77 100644
--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc
+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc
@@ -22,7 +22,7 @@ const int kMaxBitmapSize = 256;
////////////////////////////////////////////////////////////////////////////////
// FaviconRawBitmapHandler fetchs all bitmaps with the 'icon' (or 'shortcut
// icon')
-// link tag, storing the one that best matches ash::kShelfSize.
+// link tag, storing the one that best matches ash::SHELF_SIZE.
tdanderson 2016/05/26 22:55:56 nit: ash::ShelfLayoutConstant::SHELF_SIZE.
yiyix 2016/06/02 03:54:54 Done.
// These icon bitmaps are not resized and are not cached beyond the lifetime
// of the class. Bitmaps larger than kMaxBitmapSize are ignored.
@@ -145,7 +145,7 @@ void FaviconRawBitmapHandler::AddFavicon(const GURL& image_url,
if (new_bitmap.height() > kMaxBitmapSize ||
new_bitmap.width() > kMaxBitmapSize)
return;
- if (new_bitmap.height() < ash::kShelfSize)
+ if (new_bitmap.height() < ash::GetShelfLayoutConstant(ash::SHELF_SIZE))
return;
if (!bitmap_.isNull()) {
// We want the smallest icon that is large enough.

Powered by Google App Engine
This is Rietveld 408576698