ash/system/web_notification/web_notification_tray.cc - Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/web_notification/web_notification_tray.cc

Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/system/tray/tray_constants.cc ('K') | « ash/system/web_notification/ash_popup_alignment_delegate.cc ('k') | ash/test/shelf_view_test_api.cc » ('j') | chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/system/web_notification/web_notification_tray.cc

diff --git a/ash/system/web_notification/web_notification_tray.cc b/ash/system/web_notification/web_notification_tray.cc

index e8c9e70bc73f43388104dcc6546d6b0ba0f2b15a..50d7f5fff6e90eb4607372c0833648ea3ea57a36 100644

--- a/ash/system/web_notification/web_notification_tray.cc

+++ b/ash/system/web_notification/web_notification_tray.cc

@@ -253,7 +253,8 @@ bool WebNotificationTray::ShowMessageCenterInternal(bool show_settings) {

? GetShelfLayoutManager()->GetIdealBounds().y()

: status_area_window->GetBoundsInRootWindow().bottom();

- message_center_bubble->SetMaxHeight(std::max(0, max_height - kTraySpacing));

+ message_center_bubble->SetMaxHeight(

+ std::max(0, max_height - kMessageCenterBubblePadding));

tdanderson 2016/05/26 22:55:56 I could be mistaken but shouldn't this still be Ge

yiyix 2016/06/02 03:54:54 You are right.

if (show_settings)

message_center_bubble->SetSettingsVisible();

message_center_bubble_.reset(