Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: chrome/browser/io_thread.cc

Issue 1998863002: QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/io_thread_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 5d6949b978786da0d78f4bfb6481901a5a58e75a..7a17d92217dedd6ebee99d0949d7daf065a32a37 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -1451,8 +1451,13 @@ int IOThread::NetworkSessionConfigurator::GetQuicSocketReceiveBufferSize(
// static
bool IOThread::NetworkSessionConfigurator::ShouldQuicDelayTcpRace(
const VariationParameters& quic_trial_params) {
- return base::LowerCaseEqualsASCII(
- GetVariationParam(quic_trial_params, "delay_tcp_race"), "true");
+ std::string delay_tcp_race = GetVariationParam(quic_trial_params,
ramant (doing other things) 2016/05/20 00:00:49 Hi Ryan, Another option is to rename this parame
Ryan Hamilton 2016/05/20 03:17:27 Yeah, it seems like that would be a better idea.
ramant (doing other things) 2016/05/24 16:52:02 Done.
+ "delay_tcp_race");
+ // If "delay_tcp_race" parameter is not set, then default it to the default
+ // value which is true. Otherwise, if it is set, then return the value set by
+ // the parameter.
+ return delay_tcp_race.empty() || base::LowerCaseEqualsASCII(delay_tcp_race,
+ "true");
}
// static
« no previous file with comments | « no previous file | chrome/browser/io_thread_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698