third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp - Issue 1998783002: [IME] Fire 'compositionend' after 'textInput' event and all other DOM updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 1998783002: [IME] Fire 'compositionend' after 'textInput' event and all other DOM updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add DCHECK for empty text, fix ImeTest.java Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

index 541c84e4587e981ad9d84683c35c4c58037abf5f..b176244dce8033ea84b758f52b67d042185fbfce 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

@@ -372,7 +372,8 @@ TEST_F(InputMethodControllerTest, CompositionFireBeforeInput)

document().setTitle(emptyString());

controller().confirmComposition();

- EXPECT_STREQ("beforeinput.isComposing:false", document().title().utf8().data());

+ // Last 'beforeinput' should also be inside composition scope.

+ EXPECT_STREQ("beforeinput.isComposing:true", document().title().utf8().data());

}

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/core/editing/InputMethodController.cpp ('k') | no next file » | no next file with comments »