third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp - Issue 1998783002: [IME] Fire 'compositionend' after 'textInput' event and all other DOM updates

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 1998783002: [IME] Fire 'compositionend' after 'textInput' event and all other DOM updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add DCHECK for empty text, fix ImeTest.java Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/InputMethodController.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/editing/InputMethodController.h"	5 #include "core/editing/InputMethodController.h"

6	6

7 #include "core/dom/Element.h"	7 #include "core/dom/Element.h"

8 #include "core/dom/Range.h"	8 #include "core/dom/Range.h"

9 #include "core/editing/FrameSelection.h"	9 #include "core/editing/FrameSelection.h"

10 #include "core/events/MouseEvent.h"	10 #include "core/events/MouseEvent.h"

(...skipping 354 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
365 Vector<CompositionUnderline> underlines;	365 Vector<CompositionUnderline> underlines;

366 underlines.append(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));	366 underlines.append(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));

367 editable->focus();	367 editable->focus();

368	368

369 document().setTitle(emptyString());	369 document().setTitle(emptyString());

370 controller().setComposition("foo", underlines, 0, 3);	370 controller().setComposition("foo", underlines, 0, 3);

371 EXPECT_STREQ("beforeinput.isComposing:true", document().title().utf8().data( ));	371 EXPECT_STREQ("beforeinput.isComposing:true", document().title().utf8().data( ));

372	372

373 document().setTitle(emptyString());	373 document().setTitle(emptyString());

374 controller().confirmComposition();	374 controller().confirmComposition();

375 EXPECT_STREQ("beforeinput.isComposing:false", document().title().utf8().data ());	375 // Last 'beforeinput' should also be inside composition scope.

	376 EXPECT_STREQ("beforeinput.isComposing:true", document().title().utf8().data( ));

376 }	377 }

377	378

378 } // namespace blink	379 } // namespace blink

OLD	NEW