Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1998723003: DevTools: add expand/collapse-subtree to context menu for DOM elements (Closed)

Created:
4 years, 7 months ago by luoe
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add expand/collapse-subtree to context menu for DOM elements BUG=590633 Committed: https://crrev.com/6611f953abf0bbd3d92032b1adc3ca54380b845f Cr-Commit-Position: refs/heads/master@{#395226}

Patch Set 1 #

Patch Set 2 : Address patch 1 comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
luoe
Do you think the labels "Expand subtree"/"Collapse subtree" make sense for recursive actions? Would it ...
4 years, 7 months ago (2016-05-20 19:28:35 UTC) #3
paulirish
"Expand all" / "Collapse all" I'm not sure its worth it to be smart about ...
4 years, 7 months ago (2016-05-20 20:29:31 UTC) #4
luoe
Sound good to me
4 years, 7 months ago (2016-05-20 20:57:36 UTC) #5
lushnikov
lgtm
4 years, 7 months ago (2016-05-20 21:23:10 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998723003/20001
4 years, 7 months ago (2016-05-20 21:51:22 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 23:26:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998723003/20001
4 years, 7 months ago (2016-05-21 01:51:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-21 01:55:29 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 01:56:44 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6611f953abf0bbd3d92032b1adc3ca54380b845f
Cr-Commit-Position: refs/heads/master@{#395226}

Powered by Google App Engine
This is Rietveld 408576698