Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1998673003: [Telemetry] Change how trace_data detects if data being added is valid. (Closed)

Created:
4 years, 7 months ago by rnephew (Reviews Here)
Modified:
4 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, alexandermont
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Change how trace_data detects if data being added is valid. BUG=catapult:#2309 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6dba7972432cb9b6867a25164fab1903d3299036

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent.py View 1 chunk +1 line, -2 lines 0 comments Download
M telemetry/telemetry/timeline/trace_data.py View 1 2 chunks +9 lines, -6 lines 0 comments Download
M telemetry/telemetry/timeline/trace_data_unittest.py View 1 1 chunk +20 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rnephew (Reviews Here)
4 years, 7 months ago (2016-05-19 21:36:41 UTC) #3
nednguyen
https://codereview.chromium.org/1998673003/diff/20001/telemetry/telemetry/timeline/trace_data.py File telemetry/telemetry/timeline/trace_data.py (right): https://codereview.chromium.org/1998673003/diff/20001/telemetry/telemetry/timeline/trace_data.py#newcode199 telemetry/telemetry/timeline/trace_data.py:199: self._raw_data[part.raw_field_name] = events We probably should concatenate the string ...
4 years, 7 months ago (2016-05-19 21:38:21 UTC) #4
rnephew (Reviews Here)
https://codereview.chromium.org/1998673003/diff/20001/telemetry/telemetry/timeline/trace_data.py File telemetry/telemetry/timeline/trace_data.py (right): https://codereview.chromium.org/1998673003/diff/20001/telemetry/telemetry/timeline/trace_data.py#newcode199 telemetry/telemetry/timeline/trace_data.py:199: self._raw_data[part.raw_field_name] = events On 2016/05/19 21:38:21, nednguyen wrote: > ...
4 years, 7 months ago (2016-05-19 21:46:42 UTC) #5
nednguyen
lgtm
4 years, 7 months ago (2016-05-19 21:51:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998673003/40001
4 years, 7 months ago (2016-05-19 21:52:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6dba7972432cb9b6867a25164fab1903d3299036
4 years, 7 months ago (2016-05-19 22:15:19 UTC) #10
Sami
4 years, 7 months ago (2016-05-20 13:02:14 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1996343002/ by skyostil@chromium.org.

The reason for reverting is: Reverting to be able to revert another patch which
is causing problems on the waterfall:

https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/bu....

Powered by Google App Engine
This is Rietveld 408576698